Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov: > From: Benson Leung <bleung@xxxxxxxxxxxx> > > usbhid->intf->needs_remote_wakeup is set when a device is opened, and is > cleared when a device is closed. > > In usbhid_open, usb_autopm_get_interface is called before setting the > needs_remote_wakeup flag, and usb_autopm_put_interface is called after > hid_start_in. However, when the device is closed in usbhid_close, we > simply reset the flag and the device stays awake even though it could be > suspended. Hi, but if the device is asleep, we do not want to wake it just to reset the flag. Please use the no resume varieties. They did not exist when this code was written and that is the reason behind the current code. As it is your patch does more harm than good. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
