Hi Julian, Oscar,
Peter, you are right and it was even for Lenovo !
Oscar, I reviewed the exact same patch proposed by Julian one month, as
you can read below.
Since he was missing some formalities in the way of submission I pointed
him to submitting-patches.rst .
I was kind of surprised at first that the value was 0x33 instead of 0x3
until I read the documentation pointers Julian provided.
I really would like this patch to become part of the linux kernel and
I hope that Julian will go through the formalities for patch submission.
Or alternatively, Oscar, can you confirm that you fully wrote the patch
yourself and just happened to have the same diff as Julian.
Dmitry, what do you suggest as the best way forward?
Thanks,
Kind regards,
Ulrik
On Fri, Apr 28, 2017 at 11:05:32PM +0200, ulrik.debie-os@xxxxxxxxx wrote:
> Date: Fri, 28 Apr 2017 23:05:32 +0200
> From: ulrik.debie-os@xxxxxxxxx
> To: Julian Exner <jexner@xxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>,
> "linux-input@xxxxxxxxxxxxxxx" <linux-input@xxxxxxxxxxxxxxx>,
> aduggan@xxxxxxxxxxxxx
> Subject: Re: Input: mouse: Trackpoint middle button not recognized on
> Thinkpad E470
> X-Mailing-List: linux-input@xxxxxxxxxxxxxxx
>
> Hi Julian,
>
> See below ..
>
> On Wed, Apr 26, 2017 at 11:18:44PM +0200, Julian Exner wrote:
> > On 26/04/17 00:10, Dmitry Torokhov wrote:
> > > Hmm.. I do not recall seeing real trackpoints with only 2 buttons. Let's
> > > try defaulting to 3 and see what happens.
> >
> > This patch assumes three buttons when the trackpoint_read command failed.
> > This is just a quick fix. trackpoint_read may fail for other reasons than
> > the extended-button-data command not being available, e.g. errors in the ps2
> > communication. A more narrow solution should check if a resend request was
> > received, resend, and if the resend failed assume three buttons.
>
> > diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
> > index 354d47e..70c3a48 100644
> > --- a/drivers/input/mouse/trackpoint.c
> > +++ b/drivers/input/mouse/trackpoint.c
> > @@ -380,8 +380,8 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
> > return 0;
> >
> > if (trackpoint_read(&psmouse->ps2dev, TP_EXT_BTN, &button_info)) {
> > - psmouse_warn(psmouse, "failed to get extended button data\n");
> > - button_info = 0;
> > + psmouse_warn(psmouse, "failed to get extended button data, assuming 3 buttons are present\n");
> > + button_info = 0x33;
> > }
> >
> > psmouse->private = kzalloc(sizeof(struct trackpoint_data), GFP_KERNEL);
>
> Good, this patch is confirmed to make the trackpoint middle button work on
> Thinkpad e570 when applied to vanilla 4.10 kernel.
>
> Now in order to submit the patch for inclusion to the linux kernel,
> and before I'll grant a Reviewed-by: tag, it would be best when you
> follow the guidelines in Documentation/SubmittingPatches
> (recently moved to : Documentation/process/submitting-patches.rst )
>
> Attention points there are:
> 2) Describe your changes
> 6) No MIME
> 11) Sign your work (Signed-off: line)
> 14) The canonical patch format
>
> Thanks,
> Kind regards,
> Ulrik
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
