Hi Jean, > > On Mon, Apr 24, 2017 at 09:42:31AM +0200, Jean Delvare wrote: > > > The tm2-touchkey driver is only useful on specific platforms. Add the > > > missing hardware dependency so that the driver is not proposed on > > > systems where the device does not exist. > > > > I'm sorry, I don't see any connection between Exynos and the > > TM2-touchkey (which is manufactured by cypress, btw). > > > > It surely does have connections with the TM2 board which happens > > to have an Exynos SoC, but that cannot be fixed from the Kconfig. > > Thanks for your constructive contribution to this discussion. > > The KEYBOARD_TM2_TOUCHKEY option name, description and help text as > well as the driver name all make it sound highly hardware specific. If > this driver is for a "generic" part from Cypress then the driver should > be renamed and the Kconfig option name and description should be > updated to reflect that. The help text should also first mention the > chip vendor and name, and only then mention that it is used on the > Exynos5433 TM2 board. > > That being said, I took a look at the driver, and while "cypress" is > indeed being mentioned as the vendor name, the chip name itself is > referred to as "tm2-touchkey", which isn't generic at all. You can't > identify the hardware under the name "tm2 touchkey" everywhere in the > driver and expect people to understand it is not board specific. > > So it really boils down to this question: is that chip a generic part > from Cypress, and if so, what is the real part number? Or was is > designed privately by Cypress specifically for Samsung for this one > board (and possibly others to come)? I knew that the naming was bringing confusion and we had a previous discussion about it with Chanwoo [1]. This is indeed a generic device from Cypress. The driver has been ported from Android's Kernel [2]; it says that the device part is cy8cmbr3xxx, but the datasheet [3] doesn't have any connection with what the TM2 board has (i.e. the registers don't match). That's why we suspected that (as you said) this might be a touch key sensor specifically designed for the TM2 board. Cypress was not that helpful. The alternative was to not provide support, but it didn't look right. Thanks, Andi [1] https://marc.info/?l=linux-kernel&m=148374097826303&w=2 [2] http://opensource.samsung.com/reception/receptionSub.do?method=sub&sub=F&searchValue=sm-n910K [3] http://www.cypress.com/documentation/datasheets/cy8cmbr3002-cy8cmbr3102-cy8cmbr3106s-cy8cmbr3108-cy8cmbr3110-cy8cmbr3116 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
