Hi Andi, On Tue, 25 Apr 2017 11:28:17 +0900, Andi Shyti wrote: > On Mon, Apr 24, 2017 at 09:42:31AM +0200, Jean Delvare wrote: > > The tm2-touchkey driver is only useful on specific platforms. Add the > > missing hardware dependency so that the driver is not proposed on > > systems where the device does not exist. > > I'm sorry, I don't see any connection between Exynos and the > TM2-touchkey (which is manufactured by cypress, btw). > > It surely does have connections with the TM2 board which happens > to have an Exynos SoC, but that cannot be fixed from the Kconfig. Thanks for your constructive contribution to this discussion. The KEYBOARD_TM2_TOUCHKEY option name, description and help text as well as the driver name all make it sound highly hardware specific. If this driver is for a "generic" part from Cypress then the driver should be renamed and the Kconfig option name and description should be updated to reflect that. The help text should also first mention the chip vendor and name, and only then mention that it is used on the Exynos5433 TM2 board. That being said, I took a look at the driver, and while "cypress" is indeed being mentioned as the vendor name, the chip name itself is referred to as "tm2-touchkey", which isn't generic at all. You can't identify the hardware under the name "tm2 touchkey" everywhere in the driver and expect people to understand it is not board specific. So it really boils down to this question: is that chip a generic part from Cypress, and if so, what is the real part number? Or was is designed privately by Cypress specifically for Samsung for this one board (and possibly others to come)? Thanks again, -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
