Re: [PATCH v14 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ksenija,

> Lee Jones <lee.jones@xxxxxxxxxx> hat am 14. März 2017 um 12:05 geschrieben:
> 
> 
> On Wed, 01 Mar 2017, Dmitry Torokhov wrote:
> 
> > On Wed, Mar 01, 2017 at 09:10:50PM +0100, Stefan Wahren wrote:

...

> > > 
> > > Since touchscreen is optional it doesn't make to try to register it, notice in the touchscreen driver there is no touchscreen, give the user a confusing error and finally disable the clock.
> > > 
> > > Here are my suggestions:
> > > 
> > > 1) Use the solution from Patch V6 but with an explaining comment that touchscreen is optional
> > > 
> > > if (!lradc->touchscreen_wire)
> > > 	return 0;
> > > 
> > > 2) Return a special error from touchscreen registration so mfd knowns this result is expected.
> > > 
> > > I'm open for better solutions.
> > > 
> > > @Lee: What's your opinion?
> > 
> > I am not Lee, but given that this module already parses touchscreen
> > properties and knows whether there is touchscreen or not, #1 seems
> > simple and logical.
> 
> Sorry for the delay, I'm currently behind on my mail due to vacation
> and conferences.
> 
> +1
> 

could you please submit a V15? It would be great to get this into 4.12.

Thanks
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux