Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 14, 2017 at 01:09:57PM +0100, Arnd Bergmann wrote:
> On Jan 13, 2017 10:42 PM, "Dmitry Torokhov" <dmitry.torokhov@xxxxxxxxx> wrote:
> > On Fri, Jan 13, 2017 at 10:34:32PM +0100, Arnd Bergmann wrote:
> > > config RMI4_F03_SERIO
> > >        tristate
> > >        depends on RMI4_CORE
> > >        depends on RMI4_F03
> > >        default RMI4_CORE
> > >        select SERIO
> > >
> > > As that avoids the 'depends on SERIO=y || RMI4_CORE=SERIO' statement that
> > > is different from the other SERIO users, it keeps it all in one place,
> > > and it doesn't
> > > prevent you from seeing the RMI4_F03 symbol when SERIO=m.
> > Hmm, if this works and resilient with user changing symbols after
> > they've been auto-selected then I like it. How can we run it through
> > multitude of randconfigs?
> 
> I've successfully run it over night on a few hundred randconfig builds without
> problems now, so I'm pretty confident it works.
> 
> The hidden option will ensure the configuration is always valid even when
> the user changes it, the only thing that can be unexpected is the same as
> every 'select': when you enable this option, SERIO will get turned on, and
> when you disable it again after leaving 'menuconfig', it stays on.

Great. Could you please send me real patch and I'll get it to Linus?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux