On January 13, 2017 1:06:12 PM PST, Arnd Bergmann <arnd@xxxxxxxx> wrote: >On Thursday, January 12, 2017 10:22:03 PM CET Dmitry Torokhov wrote: >> As it was explained townthread we can't [currently] make functions >> modules, in the meantime I have >d7ddad0acc4add42567f7879b116a0b9eea31860 >> that should fix this issue (and I just sent pull request for it). > >On today's linux-next (which includes d7ddad0acc4ad), I was still >getting this warning : > >warning: (HID_RMI) selects RMI4_F03 which has unmet direct dependencies >(!UML && INPUT && RMI4_CORE && (SERIO=y || RMI4_CORE=SERIO)) Ah, yes, that's new hid RMI code.. > >This is my fixup, though I'm not too happy with that version. > >Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > >diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >index 1aeb80e52424..3927259a5d5d 100644 >--- a/drivers/hid/Kconfig >+++ b/drivers/hid/Kconfig >@@ -785,7 +785,8 @@ config HID_SUNPLUS > config HID_RMI > tristate "Synaptics RMI4 device support" > depends on HID >- select RMI4_CORE >+ depends on SERIO && RMI4_CORE >+ depends on SERIO=y || RMI4_CORE=SERIO Shouldn't this be simply select SERIO # needed for F03 ? > select RMI4_F03 > select RMI4_F11 > select RMI4_F12 Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
