On Mon, 19 Dec 2016, Dennis Wassenberg wrote: > "led_set_func_hid_lenovo" is set to "hid_lenovo_led_set" > > +#if IS_ENABLED(CONFIG_HID_LENOVO) > +static int hda_fixup_thinkpad_hid_prepare(struct hda_codec *codec) > +{ > + struct hda_gen_spec *spec = codec->spec; > + int ret = 0; > + > + if (!is_thinkpad(codec)) > + return -ENODEV; > + if (!led_set_func_hid_lenovo) > + led_set_func_hid_lenovo = symbol_request(hid_lenovo_led_set); > > "hid_lenovo_led_set" is introduced in "[PATCH v2 2/2] hda: > thinkpad_helper: Add support for hid-lenovo LED control". This means > that "[PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED > control" can only work with applied "[PATCH 1/4] hid-lenovo: Add support > for X1 Tablet cover special keys" and "[PATCH v2 2/2] hda: > thinkpad_helper: Add support for hid-lenovo LED control". Ah, okay, I wasn't aware of the other patchset. These two probably should be merged together. Is the other 2-patch set merged in any tree already? Where has it been submitted to? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html