Hi Jiri, We had a proprietary driver for WDT8756 in /input/touchscreen. Just thought the product_id might be useful in the future. Should I remove it out ? Hn.chen. -----Original Message----- From: Jiri Kosina [mailto:jikos@xxxxxxxxxx] Sent: Thursday, November 10, 2016 4:41 PM To: Hn Chen Cc: benjamin.tissoires@xxxxxxxxxx; dmitry.torokhov@xxxxxxxxx; linux-input@xxxxxxxxxxxxxxx Subject: Re: [PATCH v3] HID:i2c-hid: add a simple quirk to fix device defects On Thu, 10 Nov 2016, hn.chen@xxxxxxxxxxxxxxx wrote: > From: HungNien Chen <hn.chen@xxxxxxxxxxxxxxx> > > Rename i2c_hid_blacklist as i2c_hid_quirks. > Make the syntax changes of macro & for_loop slightly. > > Signed-off-by: HungNien Chen <hn.chen@xxxxxxxxxxxxxxx> > --- > drivers/hid/hid-ids.h | 5 ++++ > drivers/hid/i2c-hid/i2c-hid.c | 57 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 62 insertions(+) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index > 6cfb5ca..787afdf 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -1033,6 +1033,11 @@ > #define USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH 0x0500 > #define USB_DEVICE_ID_WALTOP_SIRIUS_BATTERY_FREE_TABLET 0x0502 > > +#define USB_VENDOR_ID_WEIDA 0x2575 > +#define USB_DEVICE_ID_WEIDA_8756 0x8756 The patch looks good to me now, thanks for incorporating all the feedback. My only remaining question -- why is 0x8756 being added into hid-ids.h, but then not actually used for defining a quirk? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
