On Wed, 2016-10-19 at 09:58 +0000, Ooi, Joyce wrote: [...] > > + /* Put ISH to D3 state for power saving */ > > + pci_read_config_word(pdev, pdev->pm_cap + PCI_PM_CTRL, > > &csr); > > + > > + csr &= ~PCI_PM_CTRL_STATE_MASK; > > + csr |= PCI_D3hot; > > + pci_write_config_word(pdev, pdev->pm_cap + PCI_PM_CTRL, > > csr); > > + > > Do you think it would be cleaner if we use pci_set_power_state() ? > http://lxr.free-electrons.com/source/drivers/pci/pci.c#L877 Makes sense. I will test and update this. Thanks, Srinivas ��.n��������+%������w��{.n�����{��)��^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�