On 07 October 2016 18:02, Guenter Roeck wrote:
> > On 06 October 2016 19:49, Guenter Roeck wrote:
> > > On Thu, Oct 06, 2016 at 04:28:14PM +0000, Steve Twiss wrote:
> > > > I am using the compatible string to pick a different configuration .data block:
> > > > { .compatible = "dlg,da9062-watchdog", .data = &da9062_watchdog_info },
> > > > { .compatible = "dlg,da9061-watchdog", .data = &da9061_watchdog_info },
> > > >
> > > > But, it is just my opinion to keep the "name" different.
> > > > This will not be my decision if accepted into the Linux kernel, but I would like to
> > > > at least be consistent for DA9061 and DA9062 so ... is this an issue?
> > >
> > > FWIW the driver doesn't really need to be updated in the first place.
> > > A compatible statement listing both da9061 and da9062 would do it.
> >
> > I will make the changes you requested: deprecate the existing compatibility
> > for da9062-watchdog and make a new compatibility string which combines both
> > da9061 and da9062.
> >
> That is not what I asked for.
Ok. Did you mean separate compatible statements with data sections pointing at
the same structure?
Like this:
{ .compatible = "dlg,da9062-watchdog", .data = &da9062_watchdog_info },
{ .compatible = "dlg,da9061-watchdog", .data = &da9062_watchdog_info },
So this would be the only change needed in the device driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
