Re:[v1.1,1/3] driver: input :touchscreen : add Raydium crc touch function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>This is not offset, this is size, or length, of CRC.
I'll change namming as RM_CONTACT_CRC_SIZE

>> @@ -798,33 +803,54 @@ static void raydium_mt_event(struct raydium_data *ts)
>>  		input_mt_slot(ts->input, i);
>>  		input_mt_report_slot_state(ts->input, MT_TOOL_FINGER, state);
>>  
>> -		if (!state)
>> -			continue;
>> -
>> -		input_report_abs(ts->input, ABS_MT_POSITION_X,
>> +		if (state == 0x01) {

>Why we need this change? How is it related to CRC? Do you intent to
>report contact as active but not emit any position data of state is
>neither 0 nor 1?
This is no relationship with CRC, just want to make sure report points as state equal to 1.
Okay, I'll update to another patch.

>>  static irqreturn_t raydium_i2c_irq(int irq, void *_dev)
>>  {
>>  	struct raydium_data *ts = _dev;
>> +	int error;
>>  
>> -	if (ts->boot_mode != RAYDIUM_TS_BLDR)
>> -		raydium_mt_event(ts);
>> +	if (ts->boot_mode == RAYDIUM_TS_MAIN) {
>> +		error = raydium_i2c_read_message(ts->client, ts->data_bank_addr,
>> +				 ts->report_data, ts->pkg_size);
>> +		if (!error)
>> +			raydium_i2c_event(ts);
>> +	}
>
>This chunk seems to belong to some other patch.

Yes, I'll remove them. 

Thanks.

Jeffrey
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux