Re: [PATCH v4] input: touchscreen: Add generic driver for Silead touchscreens

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 15, 2016 at 2:39 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Hi,
>
>
> On 06/15/2016 01:27 AM, Rob Herring wrote:
>>
>> On Mon, Jun 13, 2016 at 12:46:50PM +0200, Daniel Jansen wrote:
>>>
>>> From: Robert Dolca <robert.dolca@xxxxxxxxx>
>>>
>>> This driver adds support for Silead touchscreens. It has been tested
>>> with GSL1680 and GSL3680 touch panels.
>>>
>>> It supports ACPI and device tree enumeration. Screen resolution,
>>> the maximum number of fingers supported and firmware name are
>>> configurable.

[...]

>>> b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
>>> @@ -0,0 +1,39 @@
>>> +* GSL 1680 touchscreen controller
>>> +
>>> +Required properties:
>>> +- compatible             : "silead,gsl1680"
>>> +- reg                    : I2C slave address of the chip (0x40)
>>> +- interrupt-parent       : a phandle pointing to the interrupt
>>> controller
>>> +                           serving the interrupt for this chip
>>> +- interrupts             : interrupt specification for the gsl1680
>>> interrupt
>>> +- wake-gpios             : GPIO specification for the WAKE input
>>
>>
>> What direction is this?
>
>
> This is an input to the touchscreen controller, it needs to be driven high
> to take the touchscreen controller out of its low power state.

Okay, please clarify that in the description. The gpio flags should
also indicate it is active high.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux