On 04/30/2016 01:36 AM, Dmitry Torokhov wrote:
> Hi Ksenija,
Hi all,
> On Fri, Apr 29, 2016 at 01:49:11PM +0200, Ksenija Stanojevic wrote:
>> Add mxs-lradc touchscreen driver.
>>
>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@xxxxxxxxx>
>> ---
>> drivers/input/touchscreen/Kconfig | 14 +-
>> drivers/input/touchscreen/Makefile | 1 +
>> drivers/input/touchscreen/mxs-lradc-ts.c | 729 +++++++++++++++++++++++++++++++
>> 3 files changed, 742 insertions(+), 2 deletions(-)
>> create mode 100644 drivers/input/touchscreen/mxs-lradc-ts.c
>>
>> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
>> index 8ecdc38..d614d248 100644
>> --- a/drivers/input/touchscreen/Kconfig
>> +++ b/drivers/input/touchscreen/Kconfig
>> @@ -566,7 +566,7 @@ config TOUCHSCREEN_HP600
>> depends on SH_HP6XX && SH_ADC
>> help
>> Say Y here if you have a HP Jornada 620/660/680/690 and want to
>> - support the built-in touchscreen.
>> + support the built-in touchscreen.
>>
>> To compile this driver as a module, choose M here: the
>> module will be called hp680_ts_input.
>> @@ -685,7 +685,7 @@ config TOUCHSCREEN_UCB1400
>> This enables support for the Philips UCB1400 touchscreen interface.
>> The UCB1400 is an AC97 audio codec. The touchscreen interface
>> will be initialized only after the ALSA subsystem has been
>> - brought up and the UCB1400 detected. You therefore have to
>> + brought up and the UCB1400 detected. You therefore have to
>
> Why do we have the tab in the middle of the text?
This shouldn't be a part of the patch.
>> configure ALSA support as well (either built-in or modular,
>> independently of whether this driver is itself built-in or
>> modular) for this driver to work.
[...]
>> +
>> + return 0;
>> +}
>> +
>> +static struct platform_driver mxs_lradc_ts_driver = {
>> + .driver = {
>> + .name = DRIVER_NAME_TS,
>> + },
>> + .probe = mxs_lradc_ts_probe,
>> + .remove = mxs_lradc_ts_remove,
>> +};
>> +module_platform_driver(mxs_lradc_ts_driver);
>> +
>> +MODULE_LICENSE("GPL v2");
>
> "GPL" since you are not limiting to v2 only.
The original driver ( drivers/iio/adc/mxs-lradc.c ) is GPLv2 , but
unless the license gets changed to BSD or somesuch, I don't think anyone
will really complain if it's changed to a more fitting version(s) of
GPL. I'm fine with any GPL version here.
Thanks for the thorough review, some points were new to me.
> Thanks.
>
--
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
