On Thu, 26 Nov 2015, Dmitry Torokhov wrote: > Hi Vladis, > > On Wed, Nov 25, 2015 at 04:58:08PM +0100, Vladis Dronov wrote: > > The aiptek driver crashes in aiptek_probe() when a specially crafted usb device > > without endpoints is detected. This fix adds a check that the device has proper > > configuration expected by the driver. Also an error return value is changed to > > more matching one in one of the error paths. > > Hmm, I see quite a few drivers assuming that endpoint 0 will be present. > I wonder if that should not be solved at USB level. Every USB device always has endpoint 0. If one didn't, the kernel wouldn't be able to initialize and enumerate it. > Alan, does it make sense to have drivers probe interface if it does not > have any endpoints? Yes; in theory an interface can do everything it needs using only endpoint 0. Driver shouldn't assume anything about the endpoints in the interfaces they problem. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html