Re: [PATCH v2 0/2] hid: sony: Clear and restore controller state on suspend and resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 19 Nov 2015 11:39:55 +0100
Antonio Ospite <ao2@xxxxxx> wrote:

> On Tue, 17 Nov 2015 08:57:05 -0500
> Frank Praznik <frank.praznik@xxxxxxxxx> wrote:
>  
> > > On Nov 15, 2015, at 10:30, Antonio Ospite <ao2@xxxxxx> wrote:
> [...] 
> > > 
> > > Hi Frank, the changes are basically OK, but there are warnings and
> > > errors from scripts/checkpatch.pl
> > > 
> > > Would you care to send a v3 which fixes those?
> [...]
> > 
> > I think checkpatch.pl has some issues at the moment as all of the
> > whitespace errors it reports are are single spaces and are part of the
> > patch file formatting and not in the code itself (a space at the
> > beginning of lines that don’t begin with a ‘+' or ‘-' and after the
> > final ‘—').  To be sure, I double checked that the formatting in the
> > source file was free of extra whitespace, regenerated the patches and
> > checkpatch still complains because it’s git format-patch putting the
> > spaces there (as it always has).
> 
> I tried again with checkpatch.pl from 4.4-rc1 and the errors and
> warnings seem about right: they are about the newly added lines, and
> about the commit message wrapping.
> 

OK, just saw Jiri's message, so the patches are in.

I guess I can send fixups myself then, should anything really bother
me :)

Ciao ciao,
   Antonio

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux