On Wed, 11 Nov 2015 09:49:36 -0500 Frank Praznik <frank.praznik@xxxxxxxxx> wrote: > On systems with standby power for charging devices the LEDs and rumble on the > controller can continue to function even when the system is in standby since > the state is not cleared when the system goes to sleep. > > The state on wakeup can also differ from the state when the system entered > standby as the LEDs can be cleared when the device is reset on wakeup. > > The first patch refactors the output report functions to allow sending an > output report without going through the work queue. This is necessary when > clearing the state of the controller before the system is goes into standby > since the work might not be executed before the system goes to sleep. > > The second patch implements the suspend and resume callbacks which serializes > and clears the LEDs on suspend and restores them on resume. > > Force-feedback is cleared on suspend but the state is not restored on resume > since it can potentially result in hardware damage if the device is unattended > when the system wakes. A new event will be required to resume force-feedback. > Hi Frank, the changes are basically OK, but there are warnings and errors from scripts/checkpatch.pl Would you care to send a v3 which fixes those? Thanks a lot, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
