Re: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/14/2015 08:49 AM, Wolfram Sang wrote:

This is a MFD; should be split in GPIO and I2C, then each part moved
in its respective tree.

Yes, this is the conclusion we drew last time, too. It might seem
overkill for such simple devices, still this case shows how much drivers
can suffer if missing the expertise of the apropriate subsystem. That
being said, world is full of cornercases, I agree.

This driver is a good example of that (missing expertise). It seems to be a fine HID driver but a lot of the I2C details were just wrong. At the same time, I have no idea whether the GPIO part works at all.

Anyone already working in this direction?

I'd be very surprised :)

I could and would but I'm really not in a good position to do it. My only sample hardware is in a network switch.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux