Re: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 14, 2015 at 8:54 PM, Jiri Kosina <jkosina@xxxxxxxx> wrote:
> On Mon, 13 Jul 2015, Ellen Wang wrote:
>
>> When doing an I2C_SMBUS_BYTE write (one byte write, no address),
>> the data to be written is in "command" not "data->byte".
>>
>> Signed-off-by: Ellen Wang <ellen@xxxxxxxxxxxxxxxxxxx>
>> ---
>> Forgot signed-off-by tag last time, sorry.
>
> Applied to for-4.3/cp2112.
>
> On Tue, 14 Jul 2015, Wolfram Sang wrote:
>
>> Wow, that driver seems to be largely untested. Thanks for cleaning it
>> up! Sidenote: i2c drivers should really be in drivers/i2c ;)
>
> Well, it's sometimes a bit on the borderline where HID drivers should live
> (because they often, in addition to HID layer, make use of some other
> transport). If you want to move it under your wings, please send a patch
> that moves it and I'll Ack it.


This is a MFD; should be split in GPIO and I2C, then each part moved
in its respective tree.

Anyone already working in this direction?

Regards,
Antonio
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux