On Tue, Jun 23, 2015 at 11:08:23AM -0700, Anshul Garg wrote:
> From: Anshul Garg <aksgarg1989@xxxxxxxxx>
>
> input_dev_release_keys : Use for_each_set_bit instead
> of testing every bit upto KEY_MAX as it is more clean
> and more optimized.
>
> input_estimate_events_per_packet : Use bitmap_weight
> to get set bits count for EV_REL type instead of using
> loop and also use for_each_set_bit for EV_ABS event for
> more optimized code.
>
> Signed-off-by: Anshul Garg <aksgarg1989@xxxxxxxxx>
> ---
> drivers/input/input.c | 28 ++++++++++------------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index e0b7b8e..9459f8b 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -682,12 +682,9 @@ static void input_dev_release_keys(struct input_dev *dev)
> int code;
>
> if (is_event_supported(EV_KEY, dev->evbit, EV_MAX)) {
> - for (code = 0; code <= KEY_MAX; code++) {
> - if (is_event_supported(code, dev->keybit, KEY_MAX) &&
> - __test_and_clear_bit(code, dev->key)) {
> - input_pass_event(dev, EV_KEY, code, 0);
> - }
> - }
> + for_each_set_bit(code, dev->keybit, KEY_MAX)
> + input_pass_event(dev, EV_KEY, code, 0);
> + memset(dev->keybit, 0, sizeof(dev->keybit));
I do not think this will work, you are resetting wrong bitmap.
dev->keybit represents keys the device is capable of sending while
dev->key represents keys that are currently pressed. Once your code is
ran you should not get any more key events.
How was this tested?
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
