On Fri, 1 May 2015, John Horan wrote: > The quirk for swapping the grave and 102nd keys should be applied to the > APPLE_ALU_ISO keyboard, as they aren't actually swapped. > > Signed-off-by: John Horan <knasher@xxxxxxxxx> > --- > drivers/hid/hid-apple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c > index f822fd2..e4bbfc0 100644 > --- a/drivers/hid/hid-apple.c > +++ b/drivers/hid/hid-apple.c > @@ -441,7 +441,7 @@ static const struct hid_device_id apple_devices[] = { > { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_ANSI), > .driver_data = APPLE_HAS_FN }, > { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_ISO), > - .driver_data = APPLE_HAS_FN | APPLE_ISO_KEYBOARD }, > + .driver_data = APPLE_HAS_FN }, > { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_JIS), > .driver_data = APPLE_HAS_FN }, > { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER4_HF_ANSI), Okay, this has been there since 2007, so one would guess there must be a reason for noone complaining about this for past 8 years. I'd rather be careful here so that we don't introduce any regressions. Adding Michel, who added the original quirk back in 2007 (through commit a45d82d19a6 ("HID: Add support for Apple aluminum USB keyboards")) to CC. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html