On Sat, 2 May 2015, John Reid wrote: > Hi Benjamin, all, > > Keyboard works just fine now, along with the Wacom digitiser. Thank you > very much for you help linux-input folks :) Are you OK with me adding Tested-by: John Reid <owlman.lists@xxxxxxxxx> to the patch? > Might I suggest that the macro is renamed from > USB_DEVICE_ID_LENOVO_TPPRODOCK to something like > USB_DEVICE_ID_LENOVO_TPHELIXPROKDB as this better reflects the product > name in self documenting code? Technically this is a dockable keyboard > specific to the Helix tablet, and there is also a separate "dock" available. Ah, I wouldn't be overly careful about the macro names, they are really just for basic orientation ... there have even been people suggesting we just completely drop it, and use just numeric constants directly. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
