On 03/03/2015 07:44 PM, Benjamin Tissoires wrote:
This hack is only needed for Huion tablets. It does not seem to have any effect on the other tablets handled by this device right now, but it's better to check for the product id sooner than discovering that we have messed up one tablet later. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> --- changes in v3: - stores a flag to know when to invert the bit. - add #define UCLOGIC_PEN_REPORT_ID new in v2 drivers/hid/hid-uclogic.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c index f44e72b..bdda9fd 100644 --- a/drivers/hid/hid-uclogic.c +++ b/drivers/hid/hid-uclogic.c @@ -564,6 +564,7 @@ enum uclogic_ph_id { /* Report descriptor template placeholder */ #define UCLOGIC_PH(_ID) UCLOGIC_PH_HEAD, UCLOGIC_PH_ID_##_ID +#define UCLOGIC_PEN_REPORT_ID 0x07
It would be nice to also use this macro in the replaced report descriptor itself, but this will do for now. Reviewed-by: Nikolai Kondrashov <spbnick@xxxxxxxxx> Thanks a lot, Benjamin! Nick P.S. I like the way you describe the changes between patchset versions, will have to keep it in mind and use in my own. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html