On Thu, Jan 15, 2015 at 6:43 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> On Thu, Jan 15, 2015 at 06:32:31PM +0100, Geert Uytterhoeven wrote:
>> On Thu, Jan 15, 2015 at 6:02 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>> >> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> >> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> >> @@ -18,8 +18,7 @@ adi,adt7475 +/-1C TDM Extended Temp Range I.C
>> >> adi,adt7476 +/-1C TDM Extended Temp Range I.C
>> >> adi,adt7490 +/-1C TDM Extended Temp Range I.C
>> >> adi,adxl345 Three-Axis Digital Accelerometer
>> >> -adi,adxl346 Three-Axis Digital Accelerometer
>> >> -adi,adxl34x Three-Axis Digital Accelerometer
>> >> +adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
>> >
>> > I'd rather drop 346 because there is no compatible for that one anywhere.
>> > No need to resend, I can fix it here...
>>
>> If you drop adi,adxl346, checkpatch will start complaining if it encounters
>> it in a .dts.
>
> Boah, this is annoying. That means we need an 346 entry even if it is
> not different from 345 (which is fine by me).
To be clear: you need the entry in the documentation. It can be omitted
from the driver if it's not (yet) used for matching.
> If checkpatch does it this way, that means the rule of thumb is to
> *always* have a dedicated compatible entry? Can someone confirm this?
All compatible values that are in use must be documented.
Checkpatch just greps in Documentation/devicetree/bindings/.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
