[ Reposting what I replied in bugzilla... ] Hi Jia-Ju, On Monday, December 15, 2014 10:55:21 AM Jia-Ju Bai wrote: > Recently I test linux device drivers 3.17.2, and find some potential bugs. > > The target file is drivers/input/mouse/psmouse-base.c, which is used to > build psmouse.ko. I hope you can help me check my findings: > [1] psmouse_switch_protocol is called by psmouse_connect when initializing > the driver. However, psmouse_switch_protocol may be failed and return -1, > but its return value is not checked in psmouse_connect. In my experiment of > running the driver, when psmouse_switch_protocol in psmouse_connect is > failed, the system crash will occur. psmouse_connect() calls psmouse_switch_protocol with NULL as protocol argument. When psmouse_switch_protocol() gets NULL as protocol it will not fail. Do you actually have a crash trace? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
