Hi Pramod,
Thank you for your comments.
On Thu, 31 Jul 2014 17:24:42 +0530
Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx> wrote:
> Hi Yoichi,
>
> On Thursday 31 July 2014 04:24 PM, Yoichi Yuasa wrote:
> > Signed-off-by: Yoichi Yuasa <yuasa@xxxxxxxxxxxxxx>
> > ---
> > drivers/input/touchscreen/Kconfig | 11 +
> > drivers/input/touchscreen/Makefile | 1 +
> > drivers/input/touchscreen/rohm_bu21023.c | 791 ++++++++++++++++++++++++++++++
> > drivers/input/touchscreen/rohm_bu21023.h | 255 ++++++++++
> > 4 files changed, 1058 insertions(+)
>
[snip]
> > +static inline int rohm_i2c_burst_read(struct i2c_adapter *adap,
> > + struct i2c_msg *msgs, int num)
> > +{
> > + int ret, i;
> > +
> > + if (!adap->algo->master_xfer) {
> > + dev_dbg(&adap->dev, "I2C level transfers not supported\n");
> Should it be dev_err?
Yes it is.
> > +static int rohm_bu21023_i2c_probe(struct i2c_client *client,
> > + const struct i2c_device_id *id)
> > +{
> > + struct rohm_ts_data *ts;
> > + struct device *dev = &client->dev;
> > + struct input_dev *input_dev;
> > + int ret;
> > +
> > + ts = kzalloc(sizeof(struct rohm_ts_data), GFP_KERNEL);
> Can you please move to managed resources? devm_kzalloc in this case?
I'll move these to managed resources.
> > +
> > +MODULE_DESCRIPTION("ROHM BU21023/24 Touchscreen driver");
> > +MODULE_LICENSE("GPL");
> Make it GPL v2.
> MODULE_AUTHOR missing.
I'll try to contact the original author.
Thanks,
Yoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
