Hi Yuichi, On Thu, Jul 31, 2014 at 07:54:34PM +0900, Yoichi Yuasa wrote: > Signed-off-by: Yoichi Yuasa <yuasa@xxxxxxxxxxxxxx> I few high-level comments: - please get rid of polling - it is not useful in production mode; - switch to threaded interrupts so that you do not need to manage workqueue/work/timers; - new drivers should use MT-B protocol with proper contact tracking. If device does not do good job at tracking contacts you can use input's core matching algorithm (input_mt_assign_slots). - please provide ST emulation as well (input_mt_report_pointer_emulation). - the way you requesting firmware in probe path means you need to build firmware image into kernel or be careful how you pack it to avoid timeouts on boot. Since the device properties are not changing you might want to postpone that until somebody tries to open the device. - please add error handling for IO operations. - managed resources simplify the code. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
