Re: [PATCH] HID: add missing hid usages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 25, 2014 at 1:26 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Wed, Apr 23, 2014 at 11:37:17AM +0200, Olivier Gay wrote:
>> On Wed, Apr 23, 2014 at 2:04 AM, Dmitry Torokhov
>> <dmitry.torokhov@xxxxxxxxx> wrote:
>> > On Mon, Apr 07, 2014 at 09:49:52AM +0200, Jiri Kosina wrote:
>> >> > +#define KEY_BRIGHTNESS             0x250   /* Display Brightness */
> Then it does not make sense to expose it as a key - how system should
> respond to such event? Pick a random value?

Yes, I also noticed that after sending v2. We would also need to
pass/use the linear control value.

> If we really need to support this we need ABS_BRIGHTNESS, like we have
> ABS_VOLUME.

This is not absolutely needed and the other display brightness usages
are more important (like increment, decrement or toggle). I'm sending
a new v3 without this usage.

Best regards,

Olivier
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux