On Wed, Apr 23, 2014 at 11:37:17AM +0200, Olivier Gay wrote: > On Wed, Apr 23, 2014 at 2:04 AM, Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx> wrote: > > On Mon, Apr 07, 2014 at 09:49:52AM +0200, Jiri Kosina wrote: > >> > +#define KEY_BRIGHTNESS 0x250 /* Display Brightness */ > > > > What is it supposed to do exactly? Show OSD for brightness? > > No, it's a linear control usage to (HUTTR41) "Sets brightness to a > value between logical min and max.". I'm changing the comment to /* > Set Brightness */. Then it does not make sense to expose it as a key - how system should respond to such event? Pick a random value? If we really need to support this we need ABS_BRIGHTNESS, like we have ABS_VOLUME. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
