On 2014/4/15 20:38, Laxman Dewangan wrote: > On Monday 14 April 2014 09:12 PM, Li, Aubrey wrote: >> ping... >> >> On 2014/4/10 18:48, One Thousand Gnomes wrote: >>> On Thu, 10 Apr 2014 10:11:09 +0800 >>> "Li, Aubrey" <aubrey.li@xxxxxxxxxxxxxxx> wrote: >>> >>>> When the wakeup attribute is set, GPIO button is supposed to set >>>> irqflag - IRQF_NO_SUSPEND to request irq. So when the system enters >>>> the suspend sleep mode, the GPIO irq keeps enabled and is able to >>>> wake the system up. >>>> > > I think when we say irq_wake_enable() then based on underlying HW, it > should not turn off the irq if it is require for the wakeup. I mean it > need to be handle in the hw specific callbacks to keep enabling the > wakeup irq on suspend also. I failed to see why this can't be generic to all of the GPIO buttons for suspend wakeup. Do you see any cases broken by this proposal? > For me, I have key which is interrupt based from PMIC, not based on GPIO > and on that if I set it to IRQF_EARLY_RESUME then it works fine. > IRQF_NO_SUSPEND - Do not disable this IRQ during suspend IRQF_EARLY_RESUME - Resume IRQ early during syscore instead of at device resume time. IRQF_NO_SUSPEND is exactly what I want, instead of IRQF_EARLY_RESUME. Can you please send your proposal/code to help me understand why this has to hw specific and why IRQF_EARLY_RESUME is better than IRQF_NO_SUSPEND? Thanks, -Aubrey > > > ----------------------------------------------------------------------------------- > > This email message is for the sole use of the intended recipient(s) and > may contain > confidential information. Any unauthorized review, use, disclosure or > distribution > is prohibited. If you are not the intended recipient, please contact > the sender by > reply email and destroy all copies of the original message. > ----------------------------------------------------------------------------------- > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
