On Fri, Mar 7, 2014 at 4:52 AM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote: > Hi > > On Wed, Mar 5, 2014 at 10:18 PM, Benjamin Tissoires > <benjamin.tissoires@xxxxxxxxxx> wrote: >> Alright, this is the re-spin of the last round of transport cleanup. >> >> Some minor but important modifications are here, but nothing very enthousiastic. >> >> Thanks for the reviews and the tests so far. > > Apart from some minor comments on #1 and #2, this is: Hmm, neither my mailboxes nor patchwork gives me your comments on #2... By looking at the code, (assuming you mean the same comment that you made on #1), this is not so obvious. What we can do is add an arg to cp2112_hid_output() with the report number (and pass it to hid_hw_raw_request() ). However, this function is also used by cp2112_xfer(), and there is chances that I introduce a bug if I am not careful enough. I'd rather split cp2112_hid_output() in two, one for output reports, and one for features (with the reportID as an arg). I'll send this one after this series because I would like to do some more tests. > > Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx> > Thanks a lot! Cheers, Benjamin > Thanks > David > >> Cheers, >> Benjamin >> >> Benjamin Tissoires (4): >> HID: cp2112: remove various hid_out_raw_report calls >> HID: cp2112: remove the last hid_output_raw_report() call >> HID: sony: do not rely on hid_output_raw_report >> HID: remove hid_output_raw_report transport implementations >> >> drivers/hid/hid-cp2112.c | 19 +++++++++----- >> drivers/hid/hid-sony.c | 60 ++++++++++--------------------------------- >> drivers/hid/hidraw.c | 3 ++- >> drivers/hid/i2c-hid/i2c-hid.c | 14 ---------- >> drivers/hid/uhid.c | 1 - >> drivers/hid/usbhid/hid-core.c | 19 +++++--------- >> include/linux/hid.h | 21 ++------------- >> net/bluetooth/hidp/core.c | 14 ---------- >> 8 files changed, 36 insertions(+), 115 deletions(-) >> >> -- >> 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
