Do not use kfree() on storage allocated with devm_kzalloc(), eliminating kernel panics on device removal. I'm not sure how this eluded all the patching that's been going on over the past few weeks, but somehow it did. v1.01 - fix brain hiccup in the commit message. Reported-by: Courtney Cavin <courtney.cavin@xxxxxxxxxxxxxx> Reported-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Reported-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx> Signed-off-by: Christopher Heiny <cheiny@xxxxxxxxxxxxx> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> Cc: Linux Walleij <linus.walleij@xxxxxxxxxx> Cc: David Herrmann <dh.herrmann@xxxxxxxxx> Cc: Jiri Kosina <jkosina@xxxxxxx> --- drivers/input/rmi4/rmi_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 4406a7f..3552ffb 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c @@ -743,7 +743,6 @@ static int rmi_driver_remove(struct device *dev) gpio_free(pdata->attn_gpio); kfree(data->irq_status); - kfree(data); return 0; } @@ -942,7 +941,6 @@ err_destroy_functions: err_free_mem: if (data->gpio_held) gpio_free(pdata->attn_gpio); - kfree(data); return retval < 0 ? retval : 0; } -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
