On 02/12/2014 10:36 PM, Dmitry Torokhov wrote:
On Wed, Feb 05, 2014 at 05:36:09PM -0800, Christopher Heiny wrote:
>On 02/05/2014 05:09 PM, Dmitry Torokhov wrote:
> >On Tue, Feb 04, 2014 at 03:08:12PM -0800, Christopher Heiny wrote:
> >>>On 01/23/2014 04:00 PM, Courtney Cavin wrote:
> >>>> >Cc: Christopher Heiny<cheiny@xxxxxxxxxxxxx>
> >>>> >Cc: Dmitry Torokhov<dmitry.torokhov@xxxxxxxxx>
> >>>> >Signed-off-by: Courtney Cavin<courtney.cavin@xxxxxxxxxxxxxx>
> >>>> >---
> >>>> > drivers/input/rmi4/rmi_bus.c | 4 ++--
> >>>> > drivers/input/rmi4/rmi_bus.h | 2 +-
> >>>> > drivers/input/rmi4/rmi_driver.c | 17 ++++++++++++-----
> >>>> > drivers/input/rmi4/rmi_f11.c | 4 +++-
> >>>> > 4 files changed, 18 insertions(+), 9 deletions(-)
> >>>> >
> >>>> >diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
> >>>> >index 96a76e7..8a939f3 100644
> >>>> >--- a/drivers/input/rmi4/rmi_bus.c
> >>>> >+++ b/drivers/input/rmi4/rmi_bus.c
> >>>> >@@ -37,7 +37,7 @@ static void rmi_release_device(struct device *dev)
> >>>> > kfree(rmi_dev);
> >>>> > }
> >>>> >
> >>>> >-struct device_type rmi_device_type = {
> >>>> >+static struct device_type rmi_device_type = {
> >>>> > .name = "rmi_sensor",
> >>>> > .release = rmi_release_device,
> >>>> > };
> >>>
> >>>This struct is used by diagnostic modules to identify sensor
> >>>devices, so it cannot be static.
> >
> >Then we need to declare it somewhere or provide an accessor function.
>
>Currently it's in a header not included in the patches. We'll move
>it to rmi_bus.h.
Hmm, we do have rmi_is_physical_device() to identify whether it is a
sensor or a function, so I believe we should mark all structures static
to avoid anyone poking at them.
I was poking around in the dependent code late last night and came to
the same conclusion. I'll send a micropatch later today to get it out
of the way.
--
Christopher Heiny
Senior Staff Firmware Engineer
Synaptics Incorporated
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
