Re: [PATCH 01/15] Input: synaptics-rmi4 - fix checkpatch.pl, sparse and GCC warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 04, 2014 at 03:08:12PM -0800, Christopher Heiny wrote:
> On 01/23/2014 04:00 PM, Courtney Cavin wrote:
> >Cc: Christopher Heiny <cheiny@xxxxxxxxxxxxx>
> >Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> >Signed-off-by: Courtney Cavin <courtney.cavin@xxxxxxxxxxxxxx>
> >---
> >  drivers/input/rmi4/rmi_bus.c    |  4 ++--
> >  drivers/input/rmi4/rmi_bus.h    |  2 +-
> >  drivers/input/rmi4/rmi_driver.c | 17 ++++++++++++-----
> >  drivers/input/rmi4/rmi_f11.c    |  4 +++-
> >  4 files changed, 18 insertions(+), 9 deletions(-)
> >
> >diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
> >index 96a76e7..8a939f3 100644
> >--- a/drivers/input/rmi4/rmi_bus.c
> >+++ b/drivers/input/rmi4/rmi_bus.c
> >@@ -37,7 +37,7 @@ static void rmi_release_device(struct device *dev)
> >  	kfree(rmi_dev);
> >  }
> >
> >-struct device_type rmi_device_type = {
> >+static struct device_type rmi_device_type = {
> >  	.name		= "rmi_sensor",
> >  	.release	= rmi_release_device,
> >  };
> 
> This struct is used by diagnostic modules to identify sensor
> devices, so it cannot be static.

Then we need to declare it somewhere or provide an accessor function.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux