Re: [PATCH 1/4] Input: cobalt_btns - Remove redundant dev_set_drvdata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

Now that the merge window is closed, a gentle ping on this series :)

On 6 September 2013 23:38, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> Driver core sets the data to NULL upon release or probe
> failure. Hence explicit setting is not necessary.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> Cc: Yoichi Yuasa <yuasa@xxxxxxxxxxxxxx>
> ---
>  drivers/input/misc/cobalt_btns.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/cobalt_btns.c b/drivers/input/misc/cobalt_btns.c
> index 4f77f87..b5d71d2 100644
> --- a/drivers/input/misc/cobalt_btns.c
> +++ b/drivers/input/misc/cobalt_btns.c
> @@ -131,7 +131,6 @@ static int cobalt_buttons_probe(struct platform_device *pdev)
>   err_free_mem:
>         input_free_polled_device(poll_dev);
>         kfree(bdev);
> -       dev_set_drvdata(&pdev->dev, NULL);
>         return error;
>  }
>
> @@ -144,7 +143,6 @@ static int cobalt_buttons_remove(struct platform_device *pdev)
>         input_free_polled_device(bdev->poll_dev);
>         iounmap(bdev->reg);
>         kfree(bdev);
> -       dev_set_drvdata(dev, NULL);
>
>         return 0;
>  }
> --
> 1.7.4.1
>



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux