On Mon, Sep 2, 2013 at 11:30 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Mon, Sep 2, 2013 at 11:01 PM, richard -rw- weinberger > <richard.weinberger@xxxxxxxxx> wrote: >> On Mon, Sep 2, 2013 at 8:47 PM, Tom Gundersen <teg@xxxxxxx> wrote: >>> There is plenty of consumer hardware (e.g., mac books) that does not use >>> AT keyboards or PS/2 mice. It therefore makes sense for distro kernels >>> to build the related drivers as modules to avoid loading them on hardware >>> that does not need them. As such, these options should no longer be protected >>> by EXPERT. >>> >>> Moreover, building these drivers as modules gets rid of the following ugly >>> error during boot: >>> >>> [ 2.337745] i8042: PNP: No PS/2 controller found. Probing ports directly. >>> [ 3.439537] i8042: No controller found >>> >>> Signed-off-by: Tom Gundersen <teg@xxxxxxx> >>> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> >>> --- >>> drivers/input/keyboard/Kconfig | 4 ++-- >>> drivers/input/serio/Kconfig | 6 +++--- >>> 2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig >>> index 269d4c3..2d31cec 100644 >>> --- a/drivers/input/keyboard/Kconfig >>> +++ b/drivers/input/keyboard/Kconfig >>> @@ -2,7 +2,7 @@ >>> # Input core configuration >>> # >>> menuconfig INPUT_KEYBOARD >>> - bool "Keyboards" if EXPERT || !X86 >>> + bool "Keyboards" >> >> Maybe this a stupid question, but why are you dropping the "!X86" too? > > Because the "if EXPERT" only mattered for X86. > > Apply De Morgan and it read like "do not ask the question if !EXPERT && X86". Precisely. -t -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
