Hi
On Thu, Jun 27, 2013 at 11:47 AM, Jiri Kosina <jkosina@xxxxxxx> wrote:
> On Wed, 26 Jun 2013, Dmitry Torokhov wrote:
>
>> On Sat, Jun 15, 2013 at 03:32:44PM +0200, David Herrmann wrote:
>> > --- a/include/uapi/linux/input.h
>> > +++ b/include/uapi/linux/input.h
>> > @@ -507,10 +507,14 @@ struct input_keymap_entry {
>> >
>> > #define BTN_GAMEPAD 0x130
>> > #define BTN_A 0x130
>> > +#define BTN_SOUTH 0x130
>>
>> Could we do:
>>
>> #define BTN_SOUTH 0x130
>> #define BTN_A BTN_SOUTH
>>
>> so that it is clear that BTN_A, BTN_B, etc are legacy definitions and
>> not an accidental typos that need their own key codes.
>
> Makes sense, will do that modification.
>
>> Otherwise:
>>
>> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> Thanks Dmitry. Will be taking it (with the above modification) through my
> tree.
Thanks to both of you! Looks good.
Cheers
David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
