Hi David, Jiri,
On Sat, Jun 15, 2013 at 03:32:44PM +0200, David Herrmann wrote:
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -507,10 +507,14 @@ struct input_keymap_entry {
>
> #define BTN_GAMEPAD 0x130
> #define BTN_A 0x130
> +#define BTN_SOUTH 0x130
Could we do:
#define BTN_SOUTH 0x130
#define BTN_A BTN_SOUTH
so that it is clear that BTN_A, BTN_B, etc are legacy definitions and
not an accidental typos that need their own key codes.
Otherwise:
Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> #define BTN_B 0x131
> +#define BTN_EAST 0x131
> #define BTN_C 0x132
> #define BTN_X 0x133
> +#define BTN_NORTH 0x133
> #define BTN_Y 0x134
> +#define BTN_WEST 0x134
> #define BTN_Z 0x135
> #define BTN_TL 0x136
> #define BTN_TR 0x137
> @@ -702,6 +706,11 @@ struct input_keymap_entry {
> #define KEY_CAMERA_LEFT 0x219
> #define KEY_CAMERA_RIGHT 0x21a
>
> +#define BTN_DPAD_UP 0x220
> +#define BTN_DPAD_DOWN 0x221
> +#define BTN_DPAD_LEFT 0x222
> +#define BTN_DPAD_RIGHT 0x223
> +
> #define BTN_TRIGGER_HAPPY 0x2c0
> #define BTN_TRIGGER_HAPPY1 0x2c0
> #define BTN_TRIGGER_HAPPY2 0x2c1
> --
> 1.8.3.1
>
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
