Re: [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 13 May 2013, Benjamin Tissoires wrote:

> On Wed, May 8, 2013 at 9:23 AM, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Tue, 2013-05-07 at 16:48 +0200, Benjamin Tissoires wrote:
> >> On 05/07/2013 04:38 PM, Andy Shevchenko wrote:
> >> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >> > ---
> >>
> >> I bet it will be easier to track for Jiri if you resend the full series:
> >> - the egalax reordering
> >> - the remove of the duplicate ID
> >>
> >> As mentioned previously, also remove the entry in hid-multitouch (the
> >> one containing MT_CLS_EGALAX, not the _SERIAL one).
> >
> > Then it repeats v1, doesn't it?
> 
> I can not speak for Jiri, but IMO, it's easier to say:
> "Hey Jiri, pick up the patch series  v3 for this topic", instead of
> "Hey Jiri, please pick the patch 1 from v1 and patch 2 from v4 about
> this topic."
> 
> So I would say yes, repeat v1 but add a comment in the cover letter
> explaining the changes (for example, no changes in patch 1/2, patch
> 2/2 amended like this and that).

Yes, exactly, please just do a fresh resend of the series with all the 
feedback incorporated.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux