Re: [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-05-07 at 16:48 +0200, Benjamin Tissoires wrote: 
> On 05/07/2013 04:38 PM, Andy Shevchenko wrote:
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> 
> I bet it will be easier to track for Jiri if you resend the full series:
> - the egalax reordering
> - the remove of the duplicate ID
> 
> As mentioned previously, also remove the entry in hid-multitouch (the
> one containing MT_CLS_EGALAX, not the _SERIAL one).

Then it repeats v1, doesn't it?

The difference between MT_USB_DEVICE and HID_USB_DEVICE macros is
in .group member. Does it somehow affect device matching?

> 
> Cheers,
> Benjamin
> 
> >  drivers/hid/hid-ids.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> > index 2378a0b..a5520ba 100644
> > --- a/drivers/hid/hid-ids.h
> > +++ b/drivers/hid/hid-ids.h
> > @@ -268,7 +268,6 @@
> >  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207	0x7207
> >  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C	0x720c
> >  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
> > -#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
> >  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A	0x722A
> >  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E	0x725e
> >  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262	0x7262
> > 
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux