Hi Dmitry, On Thu, Apr 11, 2013 at 2:28 AM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > Fabio Estevam <festevam@xxxxxxxxx> wrote: > >>From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> >> >>SIMPLE_DEV_PM_OPS should be inside the CONFIG_PM_SLEEP 'if' block >>because >>imx_kbd_suspend and imx_kbd_resume definitions are inside this block. > > No, it does not. It compiles just fine if CONFIG_PM_SLEEP is not defined. I am not sure how to disable CONFIG_PM_SLEEP properly in the defconfig, but I did this quick test to simulate it: --- a/drivers/input/keyboard/imx_keypad.c +++ b/drivers/input/keyboard/imx_keypad.c @@ -536,7 +536,7 @@ static int imx_keypad_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP +#if 0 static int imx_kbd_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); and then I see: CC drivers/input/keyboard/imx_keypad.o drivers/input/keyboard/imx_keypad.c:585: error: 'imx_kbd_suspend' undeclared here (not in a function) drivers/input/keyboard/imx_keypad.c:585: error: 'imx_kbd_resume' undeclared here (not in a function) make[3]: *** [drivers/input/keyboard/imx_keypad.o] Error 1 make[2]: *** [drivers/input/keyboard] Error 2 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html