On 23 November 2012 16:16, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
>> @@ -0,0 +1,43 @@
>> +STMPE Touchscreen
>> +----------------
>> +
>> +Required properties:
>> + - compatible: "st,stmpe-ts"
>
> You shouldn't be specifying a compatible string in the DT.
>
>> +Example:
>> +
>> + stmpe_touchscreen {
>> + compatible = "st,stmpe-ts";
>
> This needs to be removed.
Copying my earlier reply from stmpe-gpio patch for others to know
what i have to say on this :)
I believe these are required by the code you wrote in mfd-core.c
if (parent->of_node && cell->of_compatible) {
for_each_child_of_node(parent->of_node, np) {
if (of_device_is_compatible(np, cell->of_compatible)) {
pdev->dev.of_node = np;
break;
}
}
}
This matches compatible of child node with compatible of cell. And that's
why you have added that in your keypad mappings as well.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
