On Tuesday 20 November 2012, Stefan Nilsson wrote:
> +Optional properties:
> +- gpio-irq: platform gpio pin connected to the t5400 irq pin
> +- op-mode: operation modes to be set according to enum t5400_op_mode in t5400.h
> +
> +Example of having the t5400 on an i2c bus:
> +
> +pressure@77 {
> + compatible = "tdk-epcos,t5400";
> + reg = <0x77>;
> + gpio-irq = <18>;
> + op-mode = <1>;
The way that the "gpio-irq" is specified doesn't look right. If you want to specify
a gpio line, use the gpio binding. If you just want to specify an interrupt, use the
"interrupts" property with a proper interrupt-parent.
> + int gpio-irq;
> ...
> + if (t5400->gpio-irq > 0) {
> + error = request_threaded_irq(t5400->gpio-irq, NULL,
I'm pretty sure this doesn't even compile. '-' is not part of an identifier in C.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
