On Fri, 16 Nov 2012, Tushar Behera wrote: > No need to check whether unsigned variable is less than 0. > > CC: Jiri Kosina <jkosina@xxxxxxx> > CC: linux-usb@xxxxxxxxxxxxxxx > CC: linux-input@xxxxxxxxxxxxxxx > Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx> > --- > drivers/hid/usbhid/hiddev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c > index 14599e2..711c965 100644 > --- a/drivers/hid/usbhid/hiddev.c > +++ b/drivers/hid/usbhid/hiddev.c > @@ -625,7 +625,7 @@ static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > break; > > case HIDIOCAPPLICATION: > - if (arg < 0 || arg >= hid->maxapplication) > + if (arg >= hid->maxapplication) > break; > > for (i = 0; i < hid->maxcollection; i++) Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html