On Mon, 12 Nov 2012, Geert Uytterhoeven wrote: > On Mon, Nov 12, 2012 at 10:16 AM, Jiri Slaby <jslaby@xxxxxxx> wrote: > > In patch "HID: microsoft: fix invalid rdesc for 3k kbd" I fixed > > support for MS 3k keyboards. However the added check using memcmp and > > a compound statement breaks build on architectures where memcmp is a > > macro with parameters. The error looks there like (m68k-linux-gnu-gcc > > 4.1.2): > > hid-microsoft.c:51:18: error: macro "memcmp" passed 6 arguments, but takes just 3 > > hid-microsoft.c: In function ‘ms_report_fixup’: > > drivers/hid/hid-microsoft.c:50: error: ‘memcmp’ undeclared (first use in this function) > > hid-microsoft.c:50: error: (Each undeclared identifier is reported only once > > /hid-microsoft.c:50: error: for each function it appears in.) > > The above 3 lines were actually from a build with a different config > --- which I didn't > notice at that time --- where <linux/string.h> was not indirectly included. Still the patch needs string.h include addition, otherwise you still are able to come up with m68k config that doesn't build, do I understand it correctly? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
