On Sun, Nov 4, 2012 at 11:37 PM, Jiri Slaby <jslaby@xxxxxxx> wrote:
> On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote:
>> On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby <jslaby@xxxxxxx> wrote:
>>> + if ((quirks & MS_RDESC_3K) && *rsize == 106 &&
>>> + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff },
>>> + &rdesc[94], 4)) {
>>
>> Which version of gcc are you using?
>
> 4.7.1. But that indeed fails too if memcmp is a macro. This is of course
> not the case for x86, so that I didn't hit that. I will post a patch to
> change this to standard array accesses. (This looked prettier though.)
BTW, you also have to add
#include <linux/string.h>
as on some configs, I get
drivers/hid/hid-microsoft.c:50: error: ‘memcmp’ undeclared (first use
in this function)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
