On Wed, Oct 31, 2012 at 21:00:59, Stephen Warren wrote: > On 10/31/2012 05:54 AM, AnilKumar Ch wrote: > > Add device tree support to matrix keypad driver and usage details > > are added to device tree documentation. Driver was tested on AM335x > > EVM. > > > diff --git a/Documentation/devicetree/bindings/input/matrix-keypad.txt b/Documentation/devicetree/bindings/input/matrix-keypad.txt > > new file mode 100644 > > > +- compatible: Should be "gpio-matix-keypad" > > There's a typo there. > > Given that compatible value, shouldn't the file be named > gpio-matrix-keypad.txt then? Stephen, Thanks for the comments. I agree and I have same thing in my mind but the driver name is matrix-keypad.c. And I think we have to change the driver file names as well. (drivers/../matrix_keypad.c, linux/input/ matrix_keypad.h). > > It seems like the property linux,keymap should be mentioned here too, > with a note to read matrix-keymap.txt for the definition. I will add a point to specify "details of linux,keymap are available at matrix-keymap.txt" > > > +Optional Properties: > > > +- clustered-irq: have clustered irq number > > +- clustered-irq-flags: have clustered irq flags > > Explaining what those mean would be useful. Sure. Thanks AnilKumar -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
