On 10/31/2012 05:54 AM, AnilKumar Ch wrote: > Add device tree support to matrix keypad driver and usage details > are added to device tree documentation. Driver was tested on AM335x > EVM. > diff --git a/Documentation/devicetree/bindings/input/matrix-keypad.txt b/Documentation/devicetree/bindings/input/matrix-keypad.txt > new file mode 100644 > +- compatible: Should be "gpio-matix-keypad" There's a typo there. Given that compatible value, shouldn't the file be named gpio-matrix-keypad.txt then? It seems like the property linux,keymap should be mentioned here too, with a note to read matrix-keymap.txt for the definition. > +Optional Properties: > +- clustered-irq: have clustered irq number > +- clustered-irq-flags: have clustered irq flags Explaining what those mean would be useful. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
