On Wednesday 10 October 2012, Dmitry Torokhov wrote: > On Wed, Oct 10, 2012 at 05:12:01PM +0800, Hui Wang wrote: > > The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework > > and don't support this API anymore. > > > > The i.MX6q sabrelite platform equips an egalax touchscreen controller, > > and this platform already transfered to GENERIC_GPIO framework, to > > support this driver, we use a more generic way to get gpio. > > Unfortunately this does break the driver for platforms that do still > support irq_to_gpio and have not transitioned to device tree (yet?). > It looks like the API suffered from premature deletion... The API was changed after all users of irq_to_gpio on ARM were assumed to be converted. The remaining users either had patches back then that were not merged in time or were merged after the conversion. Right now what we have left are: drivers/ata/pata_rb532_cf.c: blackfin specific, not for ARM drivers/input/touchscreen/egalax_ts.c: currently broken, patches were sent a few times drivers/pcmcia/db1xxx_ss.c: MIPS specific drivers/power/tosa_battery.c: has been broken for a long time, ARM PXA specific drivers/staging/iio/accel/lis3l02dq_core.c: patch was sent recently, will get merged into 3.7 egalax_ts is currently the only thing that prevents us from building allyesconfig on ARM. > I really do not want to add a new platform data structure with only gpio > in it, is there a better way to detect if irq_to_gpio() (even if only a > stub) is available? There are no platforms in the mainline kernel that define an egalax_ts platforms_device, I think we can safely assume all users are either DT based, or they need out of tree patches anyway. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
