On 19/09/2012 18:58, Dmitry Torokhov wrote: > Hi Stefano, > Hi Dmitry, > On Wed, Sep 19, 2012 at 04:53:54PM +0200, Stefano Babic wrote: >> The probe function checks for integrity the pdata->irq_pin, >> but then does not request this line for interrupt. >> For this reason, no interrupts are generated. >> >> Tested on a AM3517 board with EP0700M06 > > Why is your board code does not set client->irq properly? My concern is related that there are two different setup for the irq. Near the client structure, the driver uses a an own platform data structure edt_ft5x06_platform_data, where one filed is irq_pin. In whole driver the pdata->irq_pin is used, and client->irq is used only for requesting the irq. But they contain the same information, as the irq number can be get easy from irq_pin with gpio_to_irq(). Having both, it is possible to set them to different values, and this is wrong. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@xxxxxxx ===================================================================== -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
